Modify / Delete Notification- SOLVED! with new download of 1.2.12

[dannette]

mysql: 5.0.85-community
php: 5.2.5
web server: Apache/1.3.41
api: cgi (phpsuexec)

I have had version 1.2.10 running for quite a while now. Our client told us that when they modify or delete a reservation, the participants do not get notified. I just put up the new version (1.2.11) and am having the same problem with the new version. The reservation modifies fine but no one is notified of the change. Has anyone else had success in fixing this or even encountered this problem?

[dannette]

I am responding to my own post but would like an answer please. I just looked at ResDB.class.php.
The one function called mod_res has a part in it for $users_to_invite and $users_to_remove and looks to email them but not the ones already listed as participating whether confirmed or not. What would need to be added to get them in. Is there a variable for them too that can be passed through?

[Nick]

I'll take a look at this.

[dannette]

Thanks Nick - let me know asap what I need to do. I appreciate all the work you do on this.

[kpelt]

I had the same problem.  It seems that it isn't grabbing the participating users from the form when processing a reservation.

I replaced line 148 in reserve.php

Code:

$unchanged_users = $helper->getUnchangedUsers($orig, $invited);

with the following:

Code:

$unchanged = $helper->getUnchangedUsers($orig, $invited);       //Fixed - now adds participating users to list of users to email for modifications
    if (isset($_POST['participating_users']) && count ($_POST['participating_users']) > 0) {
      $unchanged_temp = $_POST['participating_users'];
      foreach($unchanged_temp as $idx => $val) {
$parts = explode('|', $val);
$unchanged_temp2[$parts[0]] = $parts[1];
}
$unchanged_users = array_merge($unchanged, $unchanged_temp2);
    }
    else {
    $unchanged_users = $unchanged;
    }

and it seems to be working now.

[Nick]

Nice, thank you.  I'll get this fixed.

[dannette]

Well, I tried this on both the current running version and newest one,  and it still doesn't seem to be working for them.
However, now with this in place, the admin said she is getting confirmation and modification emails for each of the appointments she sets up. This is being used to schedule employees for dental practices in several states and they really need to be able to get modifications when a time is changed. Do you have any other ideas?
Thanks.

[skreien]

Dannette,

That fix works for me as well.  I get notifications on delete, modify, etc. 

[dannette]

The person who is the main assignee is notified but none of the participants are notified when an assignment (reservation) is canceled or modified. We tried with both confirmed and unconfirmed participants. BUT I'm still using the older version. I had put the fix on the newest version and had them test it but was told it still didn't work. I will go ahead with the full upgrade and have them try again.

[dannette]

Well, this happens to still be an issue that has to be sorted out. Can anybody help?? We are willing to pay to get this working properly.

[Nick]

You're still experiencing this on 1.2.12?  Are there any customizations to the code that may have reverted the bug fix?

[dannette]

Yes this is happening on the newest version. I put it up new, and put in the code above to try to get notifications to work. The only mods I made so far was to the config file and language file. There are other mods I need to make that I haven't yet while trying to sort this out.

[Nick]

Hmm, I thought this was resolved.  I'll go back and re-test this. 

[dannette]

Thanks, Nick. If you want to look at ours, let me know. It is being used, though. I was kind of thinking of trying to make a cron job to check and send out changes but don't know if that will help.

[dannette]

Hi Nick - are you getting anywhere with this? The natives are getting restless. There are some other modifications they need but I told them I didn't want to touch anything until you looked at it. I will give you access if it will help.
Thanks.