Maximum Booking Notice ignored in repeating events

[samato]

I'm trying to limit repeat bookings, and have a Maximum Booking Notice set to 168 hours.  This does successfully remove the option to click on dates more than a week ahead and prevent booking.  However, t if I set an event to repeat daily, so for a month, the system seems to ignore the maximum booking notice and repeats the event even on days when it should fail due to the maximum booking notice.  Is there some way to correct this?

[Nick]

Sounds like a bug on my part.  I'll get this on my list.

[samato]

Thanks.  It would be extremely nice if you could let me know when this is fixed.....

[tdr]

This problem still seems to exist with version 1.2.12. Any idea on a likely fix date?

thanks

[Nick]

This was not fixed.  I'll move this up in priority.  In the mean time, can you try the following changes to add_res() in lib/Reservation.class.php?

Move lines 195-197 underline 221

Code:

//195-197
if ($this->check_startdate()) {
$this->check_times(); // Check valid times
}

Code:

// line 221
$is_valid = $this->check_res($resources_to_add);

And change it slightly to

Code:

if ($this->check_startdate()) {
$is_valid = $is_valid && $this->check_times(); // Check valid times
}

If that works you'll need to make equivalent changes to mod_res()

[tdr]

Hi Nick,
Made the suggested code changes. My test case:
Set maximum booking notice to 24 hours for a resource
Try to reserve for the next 4 consecutive days.

Firstly I get this kind of "stacked" error box when saving the reservation which looks like this:

Please go back and correct errors
This resource cannot be reserved for more than 24 hours in advance
This resource cannot be reserved for more than 24 hours in advance
Please go back and correct errors
Your booking was successfully created for
Date1
Date2
Date3

The system does not book day 4.

To confirm, this is what the code looks like at line 221 of /lib/Reservation.class.php :

Code:

$is_valid = $this->check_res($resources_to_add);
if ($this->check_startdate()) {
$is_valid = $is_valid && $this->check_times(); // Check valid times
}

Also note: I haven't made the changes yet to mod_res()

thanks

[Nick]

So did it still place the reservation for days 2 and 3, even though it shouldn't have?

[saswanb]

Hello, I also had the same issue.  Following your advice, and expanding it a little after line 221:

         $is_valid = $this->check_res($resources_to_add);
         //  begin mod
         if ($this->check_startdate()) {
            $this->check_times();         // Check valid times
         }
         else {
            $is_valid=false;
         }
         //  end mod

The $is_valid set to false is needed to stop the loop from going ahead and creating the reservation anyway, even after generating the error message. 

[Nick]

This issue was fixed in the 1.2.12 release, if I remember correctly.

[saswanb]

I'm running 1.2.12 and it wasn't fixed in that release.

[Lazi]

I'm running 1.2.12 and it wasn't fixed in that release.

I have the same version and it seems that it does not work...

Can somebody write piece of code which should be add/exchange into configuration? It looks, that for many people this feature will be usefull.

Regards
Lazi

[Carmon Oksen]

This problem is still annoying me. Can someone kindly fix it out and tell us the right solution?