Allow users to modify past reservations?

[adamsorkin]

Would it be possible to modify to allow users to modify reservations in the past? We'd like be able to use this system as a usage log, as well, so users could schedule researchers as desired, but modify their reservation after they've finished to reflect actual usage time.

[Nick]

This would be 2 simple changes.

1) Add this code after line 474 in lib/Schedule.class.php

Code:

$viewable_date = true;

2) Change line 575 of lib/Reservation.class.php to:

Code:

$day_has_passed = false;

[jenkel]

Hi Nick,

How do I modify to allow user to reserve the current hour? Say currently it's 1:30 pm and user want to include 1:00 pm in their schedule.

Thanks

[Nick]

You would only want this if you are within the exact hour?  If it's 2:00 and the reservation started at 1:30, can it be modified?

[jenkel]

No, basically I want to  include the current hour in my reservation. If it's 2:00 pm, then the reservation starts at 2. If it's 2:01 to 2:59, then it should start also at 2:00. Right now, if it's 2:01, I can only start the reservation at 3:00.

Thanks

[Nick]

Try changing line 457 of lib/Reservation.class.php to this:

Code:

($this->start_date == $min_date && $this->start <= $min_time) )

[jenkel]

No, this change did not work.

[Nick]

Alright, try replacing line 453 with this code:

Code:

$min_time = ((intval($min_notice % 24) + $hour + 1) * 60);

[aliweb]

Hi,
I have already modified the lib/Reservation.class.php to allow users to modify past reservations (up to -744 hours, one month), but I also want to allow users to add new reservations in the past since we are using this as an equipment charge-out system.

It seems that users can add new reservations for the current day, even though the time has passed. So, creating past reservations would work fine IF the equipment was visible for past days (it is grayed out for days earlier than today).

The code you suggested did not work for me, and when I added the following line the bookings page was no longer viewable:

Add this code after line 474 in lib/Schedule.class.php: $viewable_date = true;

Thanks,
Alison

[Nick]

Change line 169 of lib/schedule.class.php to          

Code:

return true;

And line 459 of lib/reservation.class.php to:

Code:

$dates_valid = true;

[aliweb]

Hi Nick,

I changed the following:

Line 575 of lib/Reservation.class.php to:  $day_has_passed = false;

Line 169 of lib/schedule.class.php to: return true;

Line 459 of lib/reservation.class.php to: $dates_valid = true;

It seems to work fine, just wondering if the past reservations can be viewable in the control panel. Right now only reservations in the future show up.

Thanks!
Alison

[Nick]

Sure, comment out line 221 of lib/DBEngine.class.php and change line 226 to        

$values = array($id);

[aliweb]

Can the past and upcoming reservations be separated in the control panel?

[Nick]

You would need to do some coding to put all past reservations into one table and current/future into another.