adding new field to reservation

[panda007]

HI Nick

I have been trying to follow the pdf document that you made for adding a new field to registration and I have come to the following point

Example function for modifying an existing reservation (phpScheduleIt version 1.0, 1.1)

but I am trying to do this for 1.2x - do you have a newer version of the pdf as the code in function add_res looks quite different from the code that you say I should modify.

Thanks again for the great software!

[panda007]

Also not sure where to edit reserve.php...


Example for reading and validating the input // ... $environment = isset($_POST['environment']) ? stripslashes(htmlspecialchars($_POST['environment'])) : ''; if ($fn =='create')

If I search for ($fn =='create') I get the following lines above it

      $res->summary   = stripslashes($_POST['summary']);
      $res->allow_participation = (int)isset($_POST['allow_participation']);
      $res->allow_anon_participation = (int)isset($_POST['allow_anon_participation']);
      $res->reminderid = isset($_POST['reminderid']) ? $_POST['reminderid'] : null;
      $res->reminder_minutes_prior = isset($_POST['reminder_minutes_prior']) ? intval($_POST['reminder_minutes_prior']) : 0;
   }


Should I add the code here?

[Nick]

I don't have a new guide together yet, but I'll put aside some time to get that updated as soon as I can.

[durana]

hello guyz,

is there an update for 1.2 ?? I tried to add also but get stuck also at the same place.. 


durana

[durana]

Hello Nick,

I got this almost working...but I have a strange thing ..I followed the developerguide adding field to a reservation.

When I make a reservation, I get '0' at the environment the first time and when I modify the reservation I get the information I made...

What I did is make 2 reservations exact the same, the second one I have modified with 'test' in the environment value..see last two rows

What could be the problem ?

I have put the reservation table:

CREATE TABLE `reservations` (
  `resid` char(16) collate latin1_general_ci NOT NULL,
  `machid` char(16) collate latin1_general_ci NOT NULL,
  `scheduleid` char(16) collate latin1_general_ci NOT NULL,
  `start_date` int(11) NOT NULL default '0',
  `end_date` int(11) NOT NULL default '0',
  `starttime` int(11) NOT NULL,
  `endtime` int(11) NOT NULL,
  `created` int(11) NOT NULL,
  `modified` int(11) default NULL,
  `parentid` char(16) collate latin1_general_ci default NULL,
  `is_blackout` smallint(6) NOT NULL default '0',
  `is_pending` smallint(6) NOT NULL default '0',
  `summary` text collate latin1_general_ci,
  `allow_participation` smallint(6) NOT NULL default '0',
  `allow_anon_participation` smallint(6) NOT NULL default '0',
  `environment` text collate latin1_general_ci,  PRIMARY KEY  (`resid`),
  KEY `res_machid` (`machid`),
  KEY `res_scheduleid` (`scheduleid`),
  KEY `reservations_startdate` (`start_date`),
  KEY `reservations_enddate` (`end_date`),
  KEY `res_startTime` (`starttime`),
  KEY `res_endTime` (`endtime`),
  KEY `res_created` (`created`),
  KEY `res_modified` (`modified`),
  KEY `res_parentid` (`parentid`),
  KEY `res_isblackout` (`is_blackout`),
  KEY `reservations_pending` (`is_pending`)
) ENGINE=MyISAM DEFAULT CHARSET=latin1 COLLATE=latin1_general_ci;


('sc14934486bdd962', 'sc147e2cb63e0457', 'sc147adf2c389539', 1228086000, 1228086000, 510, 600, 1228163179, NULL, NULL, 0, 0, 'BBL', 0, 0, '0'),
('sc1493448815754f', 'sc147e2cb63e0457', 'sc147adf2c389539', 1228086000, 1228086000, 600, 720, 1228163201, 1228163218, NULL, 0, 0, 'BBL', 0, 0, 'test');

[Nick]

Did both add_res() and mod_res() in lib/db/ResDB.class.php get updated to set the new field in the queries?

[durana]

Nick,

I Think that I have done this ......but for sure I have pasted the part file:

---------------------------------

   function add_res($res, $is_parent, $users_to_invite, $resources_to_add, $accept_code) {
      $id = $this->get_new_id();

      // Insert the main reservation data
      $values = array (
               $id,
               $res->get_machid(),
               $res->get_scheduleid(),
               $res->get_start_date(),
               $res->get_end_date(),
               $res->get_start(),
               $res->get_end(),
               mktime(),
               null,
               ($is_parent ? $id : $res->get_parentid()),
               intval($res->is_blackout),
               $res->get_pending(),
               $res->get_summary(),
               $res->get_environment(),
               $res->get_allow_participation(),
               $res->get_allow_anon_participation()
            );
      
      $query = 'INSERT INTO ' . $this->get_table(TBL_RESERVATIONS) . ' VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)';
      $q = $this->db->prepare($query);
      $result = $this->db->execute($q, $values);
      $this->check_for_error($result);
      
      // Insert the user participation data
      $values = null;
      $values[] = array($id, $res->get_memberid(), 1, 0, 1, 1, null);

      foreach ($users_to_invite as $memberid => $email) {
         $values[] = array($id, $memberid, 0, 1, 0, 0, $accept_code);
      }

      $query = 'INSERT INTO ' . $this->get_table(TBL_RESERVATION_USERS) . ' VALUES(?,?,?,?,?,?,?)';
      $q = $this->db->prepare($query);
      $result = $this->db->executeMultiple($q, $values);
      $this->check_for_error($result);
      
      // Insert the additional resources data   
      if (count($resources_to_add) > 0) {
         $values = null;
         for ($i = 0; $i < count($resources_to_add); $i++) {
            $values[] = array($id, $resources_to_add[$i], 0);
         }
   
         $query = 'INSERT INTO ' . $this->get_table(TBL_RESERVATION_RESOURCES) . ' VALUES(?,?,?)';
         $q = $this->db->prepare($query);
         $result = $this->db->executeMultiple($q, $values);
         $this->check_for_error($result);
      }

      unset($values, $query);
      return $id;
   }


   /**
   * Modify current reservation time
   * If this reservation is part of a recurring group, all reservations in the
   *  group will be modified that havent already passed
   * @param Object $res reservation that we are modifying
   * @param array $users_to_invite hashtable of users to invite to this reservation
   * @param array $users_to_remove hashtable of users to remove from this reservation
   * @param array $resources_to_add array of resourceids to add to this reservation
   * @param array $resources_to_remove array of resourceids to remove from this reservation   
   * @param string $accept_code acceptance code to be used for reservation accept/decline
   */
   function mod_res($res, $users_to_invite, $users_to_remove, $resources_to_add, $resources_to_remove, $accept_code) {
      $t = new Timer("mod_res()");
      $t->start();
      
      $id = $res->get_id();
      
      // Update the main reservation data
      $values = array (
               $res->get_start_date(),
               $res->get_end_date(),
               $res->get_start(),
               $res->get_end(),
               mktime(),
               $res->get_summary(),
               $res->get_pending(),
               $res->get_environment(),
               $res->get_allow_participation(),
               $res->get_allow_anon_participation(),
               $id
            );

      $query = 'UPDATE ' . $this->get_table(TBL_RESERVATIONS)
                . ' SET '
            . ' start_date=?,'
            . ' end_date=?,'
            . ' starttime=?,'
                . ' endtime=?,'
                . ' modified=?,'
            . ' summary=?,'
            . ' is_pending=?,'
            . ' environment=?,'
            . ' allow_participation=?,'
            . ' allow_anon_participation=?'
                . ' WHERE resid=?';

      $q = $this->db->prepare($query);
      $result = $this->db->execute($q, $values);
      $this->check_for_error($result);

[Nick]

That all looks fine.  Is the environment field being set before calling add_res()?

[durana]

Nick ,

What do you mean by that, dont understand this.
How can I check that ?

Durana

[Nick]

After line 151 of reserve.php, you'll need something like:

$res->environment = isset($_POST['environment']) ? intval($_POST['environment']) : 0;

I'm just guessing on the names of the variables, so you'll need to fix those.

[durana]

nick,

the problem was that I had put all the addings after (see manual) the is_pending parts. It should be added after the
               $res->get_allow_participation(),
               $res->get_allow_anon_participation()
               $res->get_environment()

now it works with the original manual... I'll put all the changes I made later this week, for version 1.2.8

[durana]

First of all check the manual phpScheduleIt developer guide, made by Nick,
This is what I have done to make it work easy for 1.2.8.

Just an extract of the manual. all the credits go to Nick ofcourse
======================================

Step 1 :

ALTER TABLE reservations ADD COLUMN environment CHAR(50);

======================================

Step 2 :
phpScheduleIt\lib\db\ResDB.class.php

   function add_res($res, $is_parent, $users_to_invite, $resources_to_add, $accept_code) {
      $id = $this->get_new_id();

      // Insert the main reservation data
      $values = array (
               $id,
               $res->get_machid(),
               $res->get_scheduleid(),
               $res->get_start_date(),
               $res->get_end_date(),
               $res->get_start(),
               $res->get_end(),
               mktime(),
               null,
               ($is_parent ? $id : $res->get_parentid()),
               intval($res->is_blackout),
               $res->get_pending(),
               $res->get_summary(),
               $res->get_allow_participation(),
               $res->get_allow_anon_participation()
            );
      
      $query = 'INSERT INTO ' . $this->get_table(TBL_RESERVATIONS) . ' VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)';
      $q = $this->db->prepare($query);
      $result = $this->db->execute($q, $values);
      $this->check_for_error($result);

should be :

   function add_res($res, $is_parent, $users_to_invite, $resources_to_add, $accept_code) {
      $id = $this->get_new_id();

      // Insert the main reservation data
      $values = array (
               $id,
               $res->get_machid(),
               $res->get_scheduleid(),
               $res->get_start_date(),
               $res->get_end_date(),
               $res->get_start(),
               $res->get_end(),
               mktime(),
               null,
               ($is_parent ? $id : $res->get_parentid()),
               intval($res->is_blackout),
               $res->get_pending(),
               $res->get_summary(),
               $res->get_allow_participation(),
               $res->get_allow_anon_participation(),
               $res->get_environment()            );
      
      $query = 'INSERT INTO ' . $this->get_table(TBL_RESERVATIONS) . ' VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)';
      $q = $this->db->prepare($query);
      $result = $this->db->execute($q, $values);
      $this->check_for_error($result);
----------------------------------------------------------------------
Step 3 phpScheduleIt\lib\db\ResDB.class.php

   function mod_res($res, $users_to_invite, $users_to_remove, $resources_to_add, $resources_to_remove, $accept_code) {
      $t = new Timer("mod_res()");
      $t->start();
      
      $id = $res->get_id();
      
      // Update the main reservation data
      $values = array (
               $res->get_start_date(),
               $res->get_end_date(),
               $res->get_start(),
               $res->get_end(),
               mktime(),
               $res->get_summary(),
               $res->get_pending(),
               $res->get_allow_participation(),
               $res->get_allow_anon_participation(),
               $id
            );

      $query = 'UPDATE ' . $this->get_table(TBL_RESERVATIONS)
                . ' SET '
            . ' start_date=?,'
            . ' end_date=?,'
            . ' starttime=?,'
                . ' endtime=?,'
                . ' modified=?,'
            . ' summary=?,'
            . ' is_pending=?,'
            . ' allow_participation=?,'
            . ' allow_anon_participation=?'
                . ' WHERE resid=?';

Should be :
   function mod_res($res, $users_to_invite, $users_to_remove, $resources_to_add, $resources_to_remove, $accept_code) {
      $t = new Timer("mod_res()");
      $t->start();
      
      $id = $res->get_id();
      
      // Update the main reservation data
      $values = array (
               $res->get_start_date(),
               $res->get_end_date(),
               $res->get_start(),
               $res->get_end(),
               mktime(),
               $res->get_summary(),
               $res->get_pending(),
               $res->get_allow_participation(),
               $res->get_allow_anon_participation(),
               $res->get_environment(),               $id
            );

      $query = 'UPDATE ' . $this->get_table(TBL_RESERVATIONS)
                . ' SET '
            . ' start_date=?,'
            . ' end_date=?,'
            . ' starttime=?,'
                . ' endtime=?,'
                . ' modified=?,'
            . ' summary=?,'
            . ' is_pending=?,'
            . ' allow_participation=?,'
            . ' allow_anon_participation=?,'
            . ' environment=?'                . ' WHERE resid=?';

-------------------------------------------------------------------------------
Step 4
phpScheduleIt\lib\Reservation.class.php
class Reservation {
   var $id       = null;            //   Properties
   var $start_date   = null;            //
   var $end_date   = null;            //
   var $start       = null;            //
   var $end       = null;            //
   var $resource    = null;            //
   var $user      = null;            //
   var $resources = array();         //
   var $created    = null;      

Should be:
class Reservation {
   var $id       = null;            //   Properties
   var $start_date   = null;            //
   var $end_date   = null;            //
   var $start       = null;            //
   var $end       = null;            //
   var $resource    = null;            //
   var $user      = null;            //
   var $environment = null;
   var $resources = array();         //
   var $created    = null;   

-------------------------------------------------------
Step 5 phpScheduleIt\lib\Reservation.class.php


Add this after the reservation class

/**
* Returns the environment for this reservation
* @param none
* @return string environment
*/
function get_environment () {
return $this->environment;
}
----------------------------------------------------------------------
Step 6 phpScheduleIt\lib\Reservation.class.php

   function load_by_id() {
      $res = $this->db->get_reservation($this->id, Auth::getCurrentID());   // Get values from DB

      if (!$res) {   // Quit if reservation doesnt exist
         CmnFns::do_error_box($this->db->get_err());
      }

      $this->start_date = $res['start_date'];
      $this->end_date   = $res['end_date'];
      $this->start   = $res['starttime'];
      $this->end      = $res['endtime'];
      $this->resource = new Resource($res['machid']);
      $this->created   = $res['created'];
      $this->modified = $res['modified'];
      $this->parentid = $res['parentid'];
      $this->summary   = htmlspecialchars($res['summary']);
      $this->scheduleid   = $res['scheduleid'];
      $this->is_blackout   = $res['is_blackout'];
      $this->is_pending   = $res['is_pending'];
      $this->allow_participation = $res['allow_participation'];
      $this->allow_anon_participation = $res['allow_anon_participation'];
      $this->is_participant = $res['participantid'] != null;
      $reminder = new Reminder($res['reminderid']);
      $reminder->set_reminder_time($res['reminder_time']);
      $this->reminderid = $res['reminderid'];
      $this->reminder_minutes_prior = $reminder->getMinutuesPrior($this);

      $this->users = $this->db->get_res_users($this->id);

Should be:

   function load_by_id() {
      $res = $this->db->get_reservation($this->id, Auth::getCurrentID());   // Get values from DB

      if (!$res) {   // Quit if reservation doesnt exist
         CmnFns::do_error_box($this->db->get_err());
      }

      $this->start_date = $res['start_date'];
      $this->end_date   = $res['end_date'];
      $this->start   = $res['starttime'];
      $this->end      = $res['endtime'];
      $this->resource = new Resource($res['machid']);
      $this->created   = $res['created'];
      $this->modified = $res['modified'];
      $this->parentid = $res['parentid'];
      $this->summary   = htmlspecialchars($res['summary']);
      $this->scheduleid   = $res['scheduleid'];
      $this->is_blackout   = $res['is_blackout'];
      $this->is_pending   = $res['is_pending'];
      $this->allow_participation = $res['allow_participation'];
      $this->allow_anon_participation = $res['allow_anon_participation'];
      $this->environment = $res['environment'];      
                         $this->is_participant = $res['participantid'] != null;
      $reminder = new Reminder($res['reminderid']);
      $reminder->set_reminder_time($res['reminder_time']);
      $this->reminderid = $res['reminderid'];
      $this->reminder_minutes_prior = $reminder->getMinutuesPrior($this);

      $this->users = $this->db->get_res_users($this->id);

--------------------------------------------------
Step 7 phpScheduleIt\reserve.php

function process_reservation($fn) {
   $success = false;
   global $Class;
   $is_pending = (isset($_POST['pending']) && $_POST['pending']);

   if (isset($_POST['start_date'])) {         // Parse the POST-ed starting and ending dates
      $start_date = eval('return mktime(0,0,0, \'' . str_replace(INTERNAL_DATE_SEPERATOR, '\',\'', $_POST['start_date']) . '\');');
      $end_date = eval('return mktime(0,0,0, \'' . str_replace(INTERNAL_DATE_SEPERATOR, '\',\'', $_POST['end_date']) . '\');');
   }

   if (isset($_POST['resid']))
      $res = new $Class($_POST['resid'], false, $is_pending);
   else if (isset($_GET['resid']))
      $res = new $Class($_GET['resid'], false, $is_pending);
   else {
      // New reservation
      $res = new $Class(null, false, $is_pending);
      if ($_POST['interval'] != 'none') {      // Check for reservation repeation
         if ($start_date == $end_date) {
            $res->is_repeat = true;
            $days = isset($_POST['repeat_day']) ? $_POST['repeat_day'] : NULL;
            $week_num = isset($_POST['week_number']) ? $_POST['week_number'] : NULL;
            $repeat = CmnFns::get_repeat_dates($start_date, $_POST['interval'], $days, $_POST['repeat_until'], $_POST['frequency'], $week_num);
         }
         else {
            // Cannot repeat multi-day reservations
            $repeat = array($start_date);
            $res->is_repeat = false;
         }
      }
      else {
         $repeat = array($start_date);
         $res->is_repeat = false;
      }
   }

   $cur_user = new User(Auth::getCurrentID());
   $res->adminMode = Auth::isAdmin() || $cur_user->get_isadmin() || ($fn != 'create' && $cur_user->is_group_admin($res->user->get_groupids()));

   if (Auth::isAdmin() || $cur_user->get_isadmin())
   {
      $res->is_pending = false;   
   }
// ...
$environment = isset($_POST['environment']) ?
stripslashes(htmlspecialchars($_POST['environment'])) : '';
// ...   
   if ($fn == 'create' || $fn == 'modify') {
      $helper = new ReservationHelper();
      $util = new Utility();

      $orig = (isset($_POST['orig_invited_users']) && count($_POST['orig_invited_users']) > 0) ? $_POST['orig_invited_users'] : array();
      $invited = (isset($_POST['invited_users'])) ? $_POST['invited_users'] : array();
      $removed = (isset($_POST['removed_users'])) ? $_POST['removed_users'] : array();

      $users_to_remove = $helper->getRowsForRemoval($orig, $removed, $invited);
      $users_to_invite = $helper->getRowsForInvitation($orig, $invited);
      $unchanged_users = $helper->getUnchangedUsers($orig, $invited);

      $orig_resources = (isset($_POST['orig_resources']) && count($_POST['orig_resources']) > 0) ? $_POST['orig_resources'] : array();
      $selected_resources =  (isset($_POST['selected_resources']) && count($_POST['selected_resources']) > 0) ? $_POST['selected_resources'] : array();

      $resources_to_add = $util->getAddedItems($orig_resources, $selected_resources);
      $resources_to_remove = $util->getRemovedItems($orig_resources, $selected_resources);

      $res->user       = new User($_POST['memberid']);
      $res->start_date= $start_date;
      $res->end_date    = $end_date;
      $res->start      = $_POST['starttime'];
      $res->end      = $_POST['endtime'];

      $res->summary   = stripslashes($_POST['summary']);
      $res->allow_participation = (int)isset($_POST['allow_participation']);
      $res->allow_anon_participation = (int)isset($_POST['allow_anon_participation']);
      $res->reminderid = isset($_POST['reminderid']) ? $_POST['reminderid'] : null;
      $res->environment = $environment;
      $res->reminder_minutes_prior = isset($_POST['reminder_minutes_prior']) ? intval($_POST['reminder_minutes_prior']) : 0;
   }

   if ($fn == 'create') {
      $res->resource = new Resource($_POST['machid']);
      $res->scheduleid= $_POST['scheduleid'];
      $res->repeat = $repeat;
      $res->add_res($users_to_invite, $resources_to_add);
   }
   else if ($fn == 'modify') {
      $res->summary = str_replace("\n", '', $_POST['summary']);
      $res->mod_res($users_to_invite, $users_to_remove, $unchanged_users, $resources_to_add, $resources_to_remove, isset($_POST['del']), isset($_POST['mod_recur']), $environment);
   }
   else if ($fn == 'delete') {
      $res->del_res(isset($_POST['mod_recur']));
   }
   else if ($fn == 'approve') {
      $res->approve_res(isset($_POST['mod_recur']));
   }

-------------------------------------------------
Step 8 \phpScheduleIt\templates\reserve.template.php

   if (!$is_private) {
      print_summary($res->summary, $res->type);
   
   }

should be

   if (!$is_private) {
      print_summary($res->summary, $res->type);
      print_environment($res->get_environment(), $res->type);
   
   }


======================================
Step 9 \phpScheduleIt\templates\reserve.template.php

Add this afther the function print_summary($summary, $type) {



/**
* Print out the reservation summary or a box to add/edit one
* @param string $environment environment to edit
* @param string $type type of reservation
*/
function print_environment($environment, $type) {
?>
<table width="100%" border="0" cellspacing="0" cellpadding="1">
<tr class="tableBorder">
<td>
<table width="100%" border="0" cellspacing="1" cellpadding="0">
<tr>
<td class="cellColor"><?=translate('Environment')?></td>
<td class="cellColor" style="text-align: left;">
<?
if ($type == RES_TYPE_ADD || $type == RES_TYPE_MODIFY)
echo '<input type="text" name="environment" class="textbox" value="' . $environment . '"/>';
else
echo (!empty($environment) ? $environment : '');
?>
</td>
</tr>
</table>
</td>
</tr>
</table>
<?
}

[asterxiang]

Hi,

Since there is no instructions for adding fields for version 2.0 or 2.1, I went back to download version 1.2.12, and hoping the instructions would work. I found out on page 6 of the instruction, it says there are two changes (in add_res and mod_res functions) that don't apply to version 1.2 and higher. So I did all the other changes, and it didn't work. Also I tried the code change posted by durana above (although I think I did mostly the same thing according to the instruction), and it didn't work either.

I was wondering, are those two changes that don't apply to version 1.2 causing the problem? Or do I have to get version 1.0/1.1 to get it work? If so, where can I find version 1.0/1.1? I searched and couldn't find it.

I really hope there is a way to add new field when user makes reservation, because this is the top priority for us now, regardless of which version we end up using. Any help would be greatly appreciated!

Thanks,

Aster

[durana]

Hello Aster,

I have done these changes as described in version 1.2.8. and that worked for me.
Mayba Nick can help , if you give the error you have
regards
Durana

[asterxiang]

Thank you for your reply Durana! I sent an email to Nick and hopefully I can hear back from him soon!

At the meantime, if you still have original version 1.2.8, is it possible that you send me a copy of it? I can't find version 1.2.8 online, and I am not sure if the different version is the problem (I am running 1.2.12), but still wanted to give it a try if possible. If you still have the original 1.2.8, can you send me at asterxiang at gmail dot com?

Thank you so much for your help!

Aster