Blackout Broken

[jammer]

Hi Nik,

One of my admins put in a blackout from today through 2032 (by accident) and the system effectively put in the blackout but now gives us no option to remove the blackout.  I surmise we could destroy the entire schedule to get rid of it but we really didn't want to do that if it wasn't necessary.  I think its a bug because, if i put in a shorter blackout time period all works as designed.  Otherwise if you have another suggestion to remove the blackout let me know please.

Thanks

[Nick]

Why can't you delete it?

[jammer]

No option shown to delete.  Nothing, nada.  I can create a normal blackout for (say) a few days to a week and the delete option is shown.  Not for this one.  Nothing shown but the whole calendar is blacked out.

[Nick]

You should be able to delete it from the manage blackouts admin tool

[jammer]

Sorry, no.  Logged in as admin there is no option showing that this blackout even exists let alone allow it to be deleted.  The only fix I can find is to kill the entire schedule and re-create it.  I was able to reproduce this blackout issue in a test schedule by putting the date from (for example) today until 2032 (random number).  And sure enough the blackout goes into effect I have no way to delete it.

[Nick]

You'll need to change your filter criteria to have no date range. It will show up then.

[TheoretixSoftwareSolution]

I also found a bug in relation to filtering blackouts by a specific resource.

Had to patch lib/Application/Reservation/BlackoutFilter.php  at  line 60:
   

Code:

60:       $filter->_And(new SqlFilterEquals(new SqlFilterColumn(TableNames::RESOURCES, ColumnNames::RESOURCE_ID), $this->resourceId));

Became:
   

Code:

60:       $filter->_And(new SqlFilterEquals(new SqlFilterColumn('r', ColumnNames::RESOURCE_ID), $this->resourceId));

The problem was that it was trying to do resources.resource_id in a join when the table was aliased to 'r'. There may be a more official way to do this using some constant?

[Nick]

Thanks. I've fixed this for 2.3