Disable duplicate notification emails sent to reservation owner.

[tsjobom]

Hi, I'm looking for a way to remove the "owner" (the user who booked the resource) recipient from the "Notification: A Reservation Was Created" emails that is being sent to resource admin users when having $conf['settings']['reservation.notify']['resource.admin.add'] = 'true';

Right now I'm getting duplicate emails to the "owner user" who booked the resource when that users notification settings are turned on. I want the Notification email to be sent ONLY to the resource admin, NOT the user who booked the resource. Problem is I still want the "Your Reservation Was Created" email that is sent to the owner so I can't just turn off the notification for the "owner" user.

Best Regards, any help would be appreciated.

[Nick]

My suggestion would be what you described: Turn off email notifications for that user. Why doesn't that work for this situation?

[tsjobom]

Hi Nick, thanks for your reply.

If I turn off email notifications for the user, he doesn't receive the "Your Reservation Was Created" email when booking a resource.
If it is on, he receives both the "Your Reservation Was Created" and the "Notification: A Reservation Was Created" emails. I only want the first one of these to be sent to the user who booked the appointment and the latter to be sent to the resource admin.

Regards,
Tobias

[Nick]

I see. I'll put this on my list.

[tsjobom]

Thank you Nick, much appreciated.

Just an FYI, the "owner" user also gets copies for notification emails sent to application and group admins, so he might receive up to 3 copies of the "Notification: Created/Updated/Deleted" emails.

Any idea where to look in the code to modify this myself?

[IflyGC]

I'm pleased it's not just me seeing this.  I have an "admin" group with 4 users that have admin priviledges and everytime an email gets generated, the first person on the list gets an email addressed to him, a second email addressed to him and person #2, a third email with him, #2 and #3, and a 4th with all 4 recipients.
The second person gets three emails, the third person just 2 and the lucky last person only gets the one. 

The rather ugly work around was to give all 4 people a fake email address (.comm) and add a 5th person to the loop that sends an email to a distribution loop that then gets sent back to the 4 users.  Ugly, but works.

Any ideas how to fix this one?

[Nick]

a second email addressed to him and person #2, a third email with him, #2 and #3, and a 4th with all 4 recipients.

I'm not sure I understand. There's nowhere in the code appending recipients to a list. Each email is sent to only one recipient. How can I reproduce this?

[Nick]

Try changing line 86 of /lib/Application/Reservation/Notification/AdminEmailNotification.php to

if (array_key_exists($id, $adminIds) || $id == $owner->Id())

[grego]

I guess, $phpMailer should forget email address.

In /phpScheduleIt/lib/Email/EmailService.php

class EmailService implements IEmailService
{
        ...
        public function Send(IEmailMessage $emailMessage)
        {
                $this->phpMailer->ClearAddresses();
                $this->phpMailer->CharSet = $emailMessage->Charset();
                ...
         }
}

[ToniNord]

Try changing line 86 of /lib/Application/Reservation/Notification/AdminEmailNotification.php to

if (array_key_exists($id, $adminIds) || $id == $owner->Id())

Hahh, it worked for me too

Saved and bookmarked.

Thank you, all there.

[tsjobom]

grego+Nicks fixes solved this issue for me. Thanks guys!