making the summary field 'required' when booking

[dimpzor]

Hi

Been using this great software for a while, but i now need to make a few minor modifications and wonder if you can help as my php skills are little to none.
I would like the summary field to be made mandatory when placing a booking.

I've had a look through the forums and guess that i need to edit the lib/Reservation.class.php file but i'm not sure of the code needed  

Also, is there a way to show this summary permanantly on the bookings (weekly) screen ias well as (or instead of) the hover over effect?

Can anyone help? Much appreciated
Andy

[Nick]

Probably the easiest thing to do would be to modify the functions.js file check_reservation_form(f) function.

Something like:

if (f.summary == '')
{
msg += "- Summary is required\n";
}

[dimpzor]

i added this code to the functions.js file in check_reservation_form(f) function, but it appears to do nothing

(i added the extra quotation on the if f.summary == "" line)

[dimpzor]

nope, still can't get this to work.
not sure what the problem is. any ideas?

[Nick]

Interesting.  Can you add:

if (f.summary != "")
{
alert(f.summary);
}

to see what is coming across?

[dimpzor]

hi nick

adding that code displays the popup with [object HTMLTextAreaElement] message.
Clicking the ok button confirms the booking and adds it to the system.

Andy

[Gilbert Iqbal]

Your idea seems useful. I fixed it out! Thank you!

[dimpzor]

care to explain?
i still have the code set to show a popup when the summary field is empty but it still doesnt work.

if i edit the code where the f.summary != "" , it shows the popup if the summary field is empty or populated.

[Nick]

Ahh, should have been f.summary.value

[dimpzor]

hi nick

thanks, that seems to have done the trick......

[psi_newbie]

I did this exactly Nick but it didn't work. Any suggestions?

[Nick]

Can you post what you have for the check_reservation_form(f) function?

[psi_newbie]

function check_reservation_form(f) {
   var recur_ok = false;
   var days_ok = false;
   var is_repeat = false;
   var msg = "";
   
   if ((typeof f.interval != 'undefined') && f.interval.value != "none") {
      is_repeat = true;
      if (f.interval.value == "week" || f.interval.value == "month_day") {
         for (var i=0; i < f.elements["repeat_day[]"].length; i++) {
            if (f.elements["repeat_day[]"].checked == true)
               days_ok = true;
         }
      }
      else {
         days_ok = true;
      }
      
      if (f.repeat_until.value == "") {
         msg += "- Please choose an ending date\n";
         recur_ok = false;
      }
   }
   else {
      recur_ok = true;
      days_ok = true;
   }
   
   if (days_ok == false) {
      recur_ok = false;
      msg += "- Please select days to repeat on";
   }
   
   if (msg != "")
      alert(msg);
      
   return (msg == "");
   
   if (f.major.value == "") {
      msg+="-Major is required\n";
   }
   if (f.sclass.value == "") {
      msg+="-Class is required\n";
   }
   if (f.cgpa.value == "") {
      msg+="-CGPA is required\n";
   }
   if (f.summary.value == "") {
      msg+="-Summary is required\n";
   }
}

[Nick]

Try this:

Code:

function check_reservation_form(f) {
   var recur_ok = false;
   var days_ok = false;
   var is_repeat = false;
   var msg = "";
   
   if ((typeof f.interval != 'undefined') && f.interval.value != "none") {
      is_repeat = true;
      if (f.interval.value == "week" || f.interval.value == "month_day") {
         for (var i=0; i < f.elements["repeat_day[]"].length; i++) {
            if (f.elements["repeat_day[]"].checked == true)
               days_ok = true;
         }
      }
      else {
         days_ok = true;
      }
     
      if (f.repeat_until.value == "") {
         msg += "- Please choose an ending date\n";
         recur_ok = false;
      }
   }
   else {
      recur_ok = true;
      days_ok = true;
   }
   
   if (days_ok == false) {
      recur_ok = false;
      msg += "- Please select days to repeat on";
   }
   
   
   if (f.major.value == "") {
      msg+="-Major is required\n";
   }
   if (f.sclass.value == "") {
      msg+="-Class is required\n";
   }
   if (f.cgpa.value == "") {
      msg+="-CGPA is required\n";
   }
   if (f.summary.value == "") {
      msg+="-Summary is required\n";
   }

   if (msg != "")
      alert(msg);
     
   return (msg == "");

}

[psi_newbie]

It worked. Thanks